MM5 2057 Field dropdowns in searchEditor to small

[djdd]

Steps to reproduce:
1. Tree / Playlists > context menu > New AutoPlaylist...
2. Search...
----[Click here to add criteria]
----select a long field name, e.g. "track length (seconds)"
3. Sort order
----[Click here to add criteria]

I’m absolutely new to JavaScript and MM development, but I always try to figure out, how things work and try to learn new stuff, so I tried to find the solution for that issue

1. change, to fix length of search field dropdown (cbField)
\\\skin\skin_search_editor.less

Code: Select all

3 .search.fieldControl {
4     width: @units8_0;
5     margin-right: @units0_3;
6 }

change line 4 to

Code: Select all

4     width: @units12_0;

2. change, to fix length of sort order dropdown (cbSortField)
was a bit more tricky to find, because HTML Code is build by JS
\\\controls\searchEditor.js

Code: Select all

592 '<div class="closeButton nonGreedy" data-id="btnDelete" data-icon="close"></div>' +
593 '<div data-id="aSortField" class="search fieldControl clickableLabel textEllipsis">' + sortname + '</div>' +
594 '<div data-id="cbSortField" class="search" data-control-class="Dropdown" data-init-params="{readOnly: true}"></div>' +
595 '<div data-id="aDirection" class="thinControl clickableLabel textEllipsis">' + this._getDirectionText(row.ascending) + '</div>';

change line 594 to ("fieldControl" added)

Code: Select all

594 '<div data-id="cbSortField" class="search fieldControl" data-control-class="Dropdown" data-init-params="{readOnly: true}"></div>' +

Regards, Dieter

[jiri]

Nice to see that the open-source nature of MM5 UI is useful for the community!

Thanks,
Jiri

[djdd]

Thanks,

It took me hours to figure out how to fix the issue, but I learned a lot

Will this be added to the bug tracker?

Regards, Dieter

[Ludek]

Hi,
this has been already fixed as http://www.ventismedia.com/mantis/view.php?id=13854

But 2058 wasn't created and posted yet.

[djdd]

Ok, thanks
looking forward, to see if my solution is the same than yours
Regads,
Dieter