Updating of Songs Table unnecessary when ... BUG#5246

[MoDementia]

... only changing Album Comment

There is no reason to update all the tracks on an album when only the Album Comment is changed

I haven't tested Artist Comment yet but I presume it has the same code logic; which would be a bigger waste of updating all the artist tracks when only the Artist Comment is changed.

[MoDementia]

No Mantis entry

[nohitter151]

How can we test this to confirm? Have you confirmed it in 1218?

[MoDementia]

No easy script to reproduce it; would require most of DEISync code to reproduce.

[Bex]

Isn't the album comment written to all tracks in an album? (I have never checked that.)

[Mizery_Made]

The Album Comment field is saved in the Album table, much like the Artist Comment is saved in the Artist table. The only link between the Track and the Album/Artist Comment is the Artist/AlbumID, thus it shouldn't be updating anything in the Songs Table, or the Tracks themselves. It also doesn't write these fields to Tags, thus another reason it shouldn't be updating more than once for this operation.

EDIT: As for testing, you can open up the tree, find an artist you have a decent amount of tracks for. Right click it's node, selecting properties. Enter a value into the Comment box and select okay. Even though you've only changed the Artist comment, you'll see a progress bar show up "# tracks to be tagged"

EDIT 2: I've went ahead and added this into Mantis as Bug #5246

I'm seeing this behavior, and it is odd. I vaguely remember scratching my head about this a while back, can't remember if it was in the 3.0 versions or back in 2.5, but it's now in Mantis.

[Mizery_Made]

Looks to be fixed in 1219, no more "updating tracks" process.

[MoDementia]

Nice one