Genre Finder 5.0 - Updated 05/08/2012

Download and get help for different MediaMonkey Addons.

Moderators: Peke, Gurus

trixmoto
Posts: 10024
Joined: Fri Aug 26, 2005 3:28 am
Location: Hull, UK
Contact:

Re: Genre Finder 4.0 [MM2+3]

Post by trixmoto » Tue May 05, 2009 3:23 am

If you enter the url in your browser then you'll see that no tags are returned. This is Last.Fm either not having the data or not sending it, either way nothing I can do about it unfortunately. Try a different mode and see if that returns some data.
Download my scripts at my own MediaMonkey fansite.
All the code for my website and scripts is safely backed up immediately and for free using Dropbox.

aprzybylo
Posts: 301
Joined: Tue Aug 21, 2007 2:58 pm
Location: Ottawa, Canada
Contact:

Re: Genre Finder 4.0 [MM2+3]

Post by aprzybylo » Tue May 05, 2009 9:59 pm

I see but no matter who I try it's always the same. Did you make it work in at least one case?

trixmoto
Posts: 10024
Joined: Fri Aug 26, 2005 3:28 am
Location: Hull, UK
Contact:

Re: Genre Finder 4.0 [MM2+3]

Post by trixmoto » Wed May 06, 2009 4:22 am

I thought I had but apparently not. All the methods now return through a single function as the webservices now have a more standard output, so I didn't really need to test all modes in all situations. Turns out I should have test artist mode better as despite the API stated that Artist.getInfo included the tags in actual fact it doesn't seem to. I'll have to modify the script to use Artist.getTopTags instead.
Download my scripts at my own MediaMonkey fansite.
All the code for my website and scripts is safely backed up immediately and for free using Dropbox.

iamonyx
Posts: 3
Joined: Sat May 09, 2009 11:23 pm

Re: Genre Finder 4.0 [MM2+3]

Post by iamonyx » Sat May 09, 2009 11:32 pm

not sure if this is the right place to ask this, but is it at all possible for the script to run off the "Album Artist" tag? if anyone knows a way to edit the VBS file to process it this way instead, that would be pretty awesome :) i know this would cause a lot of problems when running a compilation, but compilations i manually tag. but i have a huge library of files i want to tag via Album Artist instead of just Artist.

example reason as to why this is useful:

the band A Silver Mt. Zion has gone by many different names through out their releases, while still incorporating "Silver Mt. Zion" in their name;
A Silver Mt. Zion
The Silver Mt. Zion Memorial Orchestra & Tra-La-La Band
Thee Silver Mt. Zion Memorial Orchestra & Tra-La-La Band
The Silver Mt. Zion Memorial Orchestra & Tra-La-La Band with Choir
Thee Silver Mountain Reveries

etc.etc. well for artist, i have whichever of the above tagged, but for album artist, i use just A Silver Mt. Zion. so genre finder tends to be a bit useless in situations like this.

but there are many other reasons, as well as the aforementioned, that tagging via Album Artist would reaaaaally be helpful for me.

anyone have any ideas? :)
Last edited by iamonyx on Sun May 10, 2009 12:22 am, edited 2 times in total.

iamonyx
Posts: 3
Joined: Sat May 09, 2009 11:23 pm

Re: Genre Finder 4.0 [MM2+3]

Post by iamonyx » Sat May 09, 2009 11:37 pm

on a different matter, it seems like 4.0 isn't working at all. as previously mentioned by others, it is giving blank results. previous versions of genre finder still seem to be workign fine though. i just reverted back to 3.2 and am having no problems.

jonp
Posts: 105
Joined: Tue Jan 01, 2008 8:08 am
Location: Australia

Re: Genre Finder 4.0 [MM2+3]

Post by jonp » Sun May 10, 2009 12:59 am

I have only done a quick test and v4.0 is working for me.

iamonyx
Posts: 3
Joined: Sat May 09, 2009 11:23 pm

Re: Genre Finder 4.0 [MM2+3]

Post by iamonyx » Sun May 10, 2009 1:24 am

jonp wrote:I have only done a quick test and v4.0 is working for me.
hmm. may just be intermittent server issues on last.fm's side (since i think that's where the genre data is pulled from).

trixmoto
Posts: 10024
Joined: Fri Aug 26, 2005 3:28 am
Location: Hull, UK
Contact:

Re: Genre Finder 4.0 [MM2+3]

Post by trixmoto » Mon May 11, 2009 3:26 am

An option to change the seed field for the artist mode is still on my list. It also appears the data source I'm using for artist mode is mostly incomplete so I will change the method in the next version. All the data is retrieved from Last.FM, yes.
Download my scripts at my own MediaMonkey fansite.
All the code for my website and scripts is safely backed up immediately and for free using Dropbox.

aprzybylo
Posts: 301
Joined: Tue Aug 21, 2007 2:58 pm
Location: Ottawa, Canada
Contact:

Re: Genre Finder 4.0 [MM2+3]

Post by aprzybylo » Mon May 11, 2009 9:33 pm

Anyway to have the option to list just artists in artist mode and not all songs like it was in previous 3.2 version? I mean if I want to run this script for my whole library it will probably freeze my computer for hours :-)

trixmoto
Posts: 10024
Joined: Fri Aug 26, 2005 3:28 am
Location: Hull, UK
Contact:

Re: Genre Finder 4.0 [MM2+3]

Post by trixmoto » Wed May 13, 2009 3:21 am

No I have no plans to add a mode like this. This script will work much better for an entire library than that would, but processing each track individually it stops MM from freezing as it did before with this script. Due to the caching mechanism, no extra calls are made out to Last.Fm either. Trust me, this is a much better way of doing it. :)
Download my scripts at my own MediaMonkey fansite.
All the code for my website and scripts is safely backed up immediately and for free using Dropbox.

riffcat
Posts: 13
Joined: Fri Dec 07, 2007 8:23 pm

Re: Genre Finder 4.0 [MM2+3]

Post by riffcat » Thu May 14, 2009 12:50 pm

Artist mode seems b0rked. All other modes seem to work.

MM ver. 3.1.0.1237
Genre Finder 4.0

11:49:06 AM Runmode:artists
11:49:06 AM Multiple values...
11:49:06 AM @http://ws.audioscrobbler.com/2.0/?metho ... +Kill+Kult
11:49:06 AM My Life With The Thrill Kill Kult - The Velvet Edge: Genre=[Unknown]
11:49:06 AM Using cached results...
11:49:06 AM My Life With The Thrill Kill Kult - Delicate Terror: Genre=[Unknown]
11:49:06 AM Using cached results...
11:49:06 AM My Life With The Thrill Kill Kult - Bad Life: Genre=[Unknown]
11:49:06 AM Using cached results...
11:49:06 AM My Life With The Thrill Kill Kult - Dirty Little Secrets: Genre=[Unknown]
11:49:06 AM Using cached results...
11:49:06 AM My Life With The Thrill Kill Kult - China De Sade: Genre=[Unknown]
11:49:06 AM Using cached results...
11:49:06 AM My Life With The Thrill Kill Kult - Dementia 66: Genre=[Unknown]
11:49:06 AM Using cached results...
11:49:06 AM My Life With The Thrill Kill Kult - Final Blindness: Genre=[Unknown]
11:49:06 AM Using cached results...
11:49:06 AM Clearing up...
11:49:06 AM Seconds:0.30
11:49:06 AM Queries:1
11:49:06 AM Sec/Query:0.30

trixmoto
Posts: 10024
Joined: Fri Aug 26, 2005 3:28 am
Location: Hull, UK
Contact:

Re: Genre Finder 4.0 [MM2+3]

Post by trixmoto » Fri May 15, 2009 10:42 am

trixmoto wrote:despite the API stated that Artist.getInfo included the tags in actual fact it doesn't seem to. I'll have to modify the script to use Artist.getTopTags instead.
Download my scripts at my own MediaMonkey fansite.
All the code for my website and scripts is safely backed up immediately and for free using Dropbox.

Redkill

Re: Genre Finder 4.0 [MM2+3]

Post by Redkill » Sat May 23, 2009 5:57 am

Hi, could you please tell me if the script is running actually. It doesn't find anything and the last month was working perfect. Thanks.

NeilN
Posts: 13
Joined: Sun Aug 27, 2006 10:45 am

Re: Genre Finder 4.0 [MM2+3]

Post by NeilN » Sat May 23, 2009 11:14 am

MM 3.0.7.1191 and GenreFinder 4.0

Run Mode: Album (works ok with Track)

Error #13 - Microsoft VBScript runtime error
Type mismatch: '[string: "albums"]'
File : "C:\Program Files\MediaMonkey3\Scripts\Auto\GenreFinder.vbs", Line 1748, Column: 12

trixmoto
Posts: 10024
Joined: Fri Aug 26, 2005 3:28 am
Location: Hull, UK
Contact:

Re: Genre Finder 4.0 [MM2+3]

Post by trixmoto » Sat May 23, 2009 12:16 pm

@RedKill - artist mode is not currently working. Try the debug mode or confirmation option to see if the script is running or not.

@NeilN - the local search is broken. You can fix it by finding line 1748...

Code: Select all

Dim run : run = Int(que.Item("run")) 
...and replacing it with...

Code: Select all

Dim run : run = que.Item("run")
...and finding lines 1764-1769...

Code: Select all

    Select Case run 
      Case 1
        sql = FieldToAlbumSQL(f,aid)
      Case 2
        sql = FieldToArtistSQL(f,aid)
    End Select
and replacing them with...

Code: Select all

    Select Case run 
      Case "albums"
        sql = FieldToAlbumSQL(f,aid)
      Case "artists"
        sql = FieldToArtistSQL(f,aid)
    End Select
...and finding lines 1806-1811...

Code: Select all

  Select Case run
    Case 1
      Call cac.Add("Album"&aid,dic)
    Case 2
      Call cac.Add("Artist"&aid,dic)
  End Select
...and replacing them with...

Code: Select all

  Select Case run
    Case "ablums"
      Call cac.Add("Album"&aid,dic)
    Case "artists"
      Call cac.Add("Artist"&aid,dic)
  End Select
...or waiting for the next version.
Download my scripts at my own MediaMonkey fansite.
All the code for my website and scripts is safely backed up immediately and for free using Dropbox.

Post Reply