Thank you very much!

My problem was that I declared the variables with let or const instead of using var.

Your explanation solved my issue.

var xVar = 1;
window.xWindow = 2;
const xConst = 3;
let xLet = 4;

I believe that init.js runs within the main window scope but inside of a code block. So the following code inside init.js:

[code]
var xVar = 1;
window.xWindow = 2;
const xConst = 3;
let xLet = 4;
[/code]

results in xVar and xWindow being accessible from the window scope, but not xConst and xLet, because const and let are [url=https://www.freecodecamp.org/news/var-let-and-const-whats-the-difference/]scoped differently from var[/url].

The screenshot shows devtools open on the main window on the left, and on a dialog window on the right.
[img]https://i.imgur.com/KJfdcBo.png[/img]

Hi,

I'm sorry. I think I missed your answer from about a year ago.

I'd like to rephrase my question. I think I understand better what I'm missing.

I'm using the mainWindow._window to set variables from one secondary window that will be used in another secondary window. This works.

The problem is that I set several variables with initial values in the init.js but I've just realized that I don't know how to get their values.

What would be the way to do that?

Marcelo

Essentially, any script that's NOT running inside a separate dialog window is running inside the main window.

Examples of scripts that run inside the main window:
[list]
[*] addon's init.js
[*] actions.js
[*] mainwindow.js
[*] templates.js
[/list]

Examples of scripts that do NOT run inside the main window:
[list]
[*] addon's config.js
[*] Anything inside the "dialogs" folder
[/list]

Scripts inside the "controls" folder may run either inside the main window OR inside a dialog window, depending on where it's initiated from. For example, Tools -> Equalizer has several Slider controls which exist inside the Equalizer dialog window, but the volume bar at the bottom of the main window exist, as you can probably guess, inside the main window.

[quote=drakinite post_id=500350 time=1661023196 user_id=107828]
There are many ways you can do it, but here's an example with custom events. You can pass data through the [b]detail[/b] parameter of createNewCustomEvent(). See: https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/CustomEvent

Main window:
[img]https://i.imgur.com/vxTZxup.png[/img]

Dialog window:
[img]https://i.imgur.com/75tsCEd.png[/img]

Quick explainer on the first two lines: [b]app.dialogs.getMainWindow()[/b] returns a SharedWindow object (from our Delphi code), but its [b]_window[/b] property gives you access to the regular JS Window object, allowing you to listen to custom events.

Regarding the playListPos shenanigans: I forgot to check that out. Let's see...
[/quote]

Thank you drakinite!

I've just started to try your suggestion. I have a question: where should I define the custom event variable and function so it is recognized in the _window property of the "Main window". I guess I mean to ask: where is the "main window" source where I should define the custom event? Is it in the init.js?

Thanks,
Marcelo

[quote=marceros post_id=500113 time=1660327288 user_id=65390]
Let's say I have 10 songs in the player and the fifth song (playListPos=6) is now playing. Then, I move the sixth song to the place before the playing song so the moved song got the fifth place in the list and the playing song got the sixth place. The playListPos now should show 7 but it still shows 6.

Then I realized that I was reading the playListPos outside the tracklist locked function. Once I moved it into the function, it started working good.

Thank you!
[/quote]

I assume you mean [i]sixth song (playlistPos=5)[/i], since the list positions are zero indexed?

I can reproduce the problem, tracked as https://www.ventismedia.com/mantis/view.php?id=19319

There are many ways you can do it, but here's an example with custom events. You can pass data through the [b]detail[/b] parameter of createNewCustomEvent(). See: https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/CustomEvent

Main window:
[img]https://i.imgur.com/vxTZxup.png[/img]

Dialog window:
[img]https://i.imgur.com/75tsCEd.png[/img]

Quick explainer on the first two lines: [b]app.dialogs.getMainWindow()[/b] returns a SharedWindow object (from our Delphi code), but its [b]_window[/b] property gives you access to the regular JS Window object, allowing you to listen to custom events.

Regarding the playListPos shenanigans: I forgot to check that out. Let's see...

actions.openDanceFloorDisplay = {
    title: _('Dance floor display') + '...',
    hotkeyAble: true,
    // icon: 'openDanceFloorDisplay',
    // disabled: uitools.notMediaListSelected,
    visible: window.uitools.getCanEdit,
    execute: async function () {
        var dlg = uitools.openDialog('dlgDanceFloorDisplay', {
			left: 100,
			top: 100,
			width: 500,
			height: 500,
            show: true,
            modal: false,
            title: _('Dance floor display'),
            // tracks: list
        });
    }
}

Hello!

My program looks stable and does the main logics of the job. Before I write the next question/problem, I'd like to explain in a line or two what the program does.

I added a menu in the MM5 main window that opens a second window. Following is the code in the actions_add.js

[code]
actions.openDanceFloorDisplay = {
title: _('Dance floor display') + '...',
hotkeyAble: true,
// icon: 'openDanceFloorDisplay',
// disabled: uitools.notMediaListSelected,
visible: window.uitools.getCanEdit,
execute: async function () {
var dlg = uitools.openDialog('dlgDanceFloorDisplay', {
left: 100,
top: 100,
width: 500,
height: 500,
show: true,
modal: false,
title: _('Dance floor display'),
// tracks: list
});
}
}
[/code]

That window goes to a second screen and displays information (to the people in the dance floor) about the theme that is playing and the following themes. All the logic is done in the JS of the open dialog and that's the part that I'm happy with.

Now I need to control the dialog from outside - from the main MM menu. Let's say that the second screen is different than expected and I have to change some internal parameters that control the text size and the height of the lines. Or I might want to change the text of the first line (title) showing on the second screen.

I guess the question is how I send data to the dialog JS (dlgDanceFloorDisplay.js) and how I run an update function in that JS, everything initiated from a menu in the main MM window.

Thank you in advance,
Marcelo

I figured out how to use the 'change' event on the 'getSongList' method. I'm using the events with the parameter 'delete' and with no parameter and everything works fine besides the fact that it triggers the event several unnecessary times. I assume the triggers will be more accurate when the

But meanwhile, I found another strange behavior with the app.player.playListPos.

Let's say I have 10 songs in the player and the fifth song (playListPos=6) is now playing. Then, I move the sixth song to the place before the playing song so the moved song got the fifth place in the list and the playing song got the sixth place. The playListPos now should show 7 but it still shows 6.

Then I realized that I was reading the playListPos outside the tracklist locked function. Once I moved it into the function, it started working good.

Thank you!

Thank you!

I think I need to do some homework.

app.listen(app.player.getSongList(), 'change', function (changeType) {
    if (changeType === undefined) {
        console.log('Song list has been rearranged');
    }
})

[quote=marceros post_id=499397 time=1658430878 user_id=65390]
And in that case, I have to set a loop where the list variable gets the new list and the "change event" does the rest.
[/quote]

No, no need for a loop. I was just giving a general coding suggestion. [b]app.listen(app.player.getSongList(), ...)[/b] is still valid; but if you want to access thisSongList inside your event handler, you won't have to do app.player.getSongList() multiple times.

[code]
app.listen(app.player.getSongList(), 'change', function (changeType) {
if (changeType === undefined) {
console.log('Song list has been rearranged');
}
})
[/code]

Maybe I understand now. So I'm actually checking the change in a list, not an event as I'm used to. Is it right?

And in that case, I have to set a loop where the list variable gets the new list and the "change event" does the rest.

Am I seeing it right?

Thank you!

let thisSongList = app.player.getSongList();
app.listen(thisSongList, 'change', function (changeType) {
	// do stuff
});

Yep. Though it may be a better idea to store the list as a variable first.

[code]
let thisSongList = app.player.getSongList();
app.listen(thisSongList, 'change', function (changeType) {
// do stuff
});
[/code]
(I haven't tested that code, but it should work)

Thank you for the response!

Can you show me how the workaround line looks?

Maybe something like:

app.listen(app.player.getSongList(), 'change', eventFunction);

Thanks,
Marcelo

Hi Marcelo,
thanks for reporting, it really fails to work for re-order and deletions.

To be fixed as https://www.ventismedia.com/mantis/view.php?id=19266

Workaround is to listen 'change' event on app.player.getSongList()
https://www.mediamonkey.com/docs/api/classes/Player.html#method_getSongList