downloadPromise = app.utils.web.getURLContentAsync(str, {

 if ((Content) && (Content != ''))

Did you saw my reply here: https://www.mediamonkey.com/forum/viewtopic.php?p=486799#p486799
and my breakpoint in NotifyWebReq funct: https://www.dropbox.com/s/yv60573my7heubm/Screenshot%202021-09-10%2021.31.10.png?dl=0


Are you saying that opening DevTools and putting breakpoint e.g. to line
[code] downloadPromise = app.utils.web.getURLContentAsync(str, {[/code]
does not stop there for you ?

Or alternatively later at line:
[code] if ((Content) && (Content != ''))[/code]

But maybe better for you is to put breakpoint directly in cleanupLyrics() funct that does clean the lyrics to be without HTML elements/tags.
Supposing that you are using cleanupLyrics in rGenius.onSuccess ?
Alernatively put breakpoint at the beginning of rGenius.onSuccess

EDIT: When I was reviewing the Genius sources here: https://www.mediamonkey.com/forum/viewtopic.php?p=486709#p486709
I found that NotifyWebReq and LoadWebPageFailed functions redundant. They are already in the original lyricsSearch.js, not sure why the script author added it there, but I think they should be removed from the script (not overriding the native variants)

So, I still want to debug this and still no solution for the Chrome debugger not stopping at the point of interest...

Anyone has got any hint for me?

rGenius.host = 'https://genius.com/%artist%-%title%-lyrics';

So, still no success with the above given track and Genius lyrics search :(
Still getting some html code mixed with the lyrics itselft.

I tried to debug this after noticing I need Chrome installed (running exclusively Firefox) to get the debug running :D
Nevertheless I added a breakpoint in source helpers\lyricsSearch.js at line ~986
[code]rGenius.host = 'https://genius.com/%artist%-%title%-lyrics';[/code]

After opening the tracks' properties I switched to Lyrics tab and executed the lyrics search. I assumed it stops at the line I previously added a breakpoint - but it didn't.

So any hint available how I could stop at the time lyrics search is running or better when Genius search gets called? FYI it does not stop either when setting up a breakpoint at any line in lyricsSearch.js.

Of course Genius as a source for lyrics lookup is active in settings.

See https://www.mediamonkey.com/forum/viewtopic.php?f=32&t=100026

[quote=Peke post_id=486588 time=1631063326 user_id=213]
Hi,
Are you using 5.0.2.2500 beta as in that version all HTML tags should be stripped.
[/quote]

Yes, I do!

Can I debug this at the time the lyrics get fetched? As mentioned above, I'm running the beta, debug version, so I assume the Chrome console should do the job, right.

Did not try it myself because of lack of some information how to debug inside MM.

Hi,
Are you using 5.0.2.2500 beta as in that version all HTML tags should be stripped.

[Verse 1]
<a href="/4794116/London-grammar-nightcall/Im-giving-you-a-nightcall-to-tell-you-how-i-feel-im-gonna-drive-you-through-the-night-down-the-hills-im-gonna-tell-you-something-you-dont-want-to-hear-im-gonna-show-you-where-its-dumped-but-have-no-fear" class="ReferentFragment__ClickTarget-oqvzi6-0 evuxZm

Title: "Nightcall (Raaja Bones & Fyfe Dangerfield Remix)"
Artists: "London Grammar"
Album: "Nightcall"
Album Artists: "London Grammar"

[quote=drakinite post_id=486367 time=1630705634 user_id=107828]
Approved! :slight_smile:
[/quote]
Guess I've found a bug when seeking for lyrics for the below mp3 file.
Genius returns in this case:
[code][Verse 1]
<a href="/4794116/London-grammar-nightcall/Im-giving-you-a-nightcall-to-tell-you-how-i-feel-im-gonna-drive-you-through-the-night-down-the-hills-im-gonna-tell-you-something-you-dont-want-to-hear-im-gonna-show-you-where-its-dumped-but-have-no-fear" class="ReferentFragment__ClickTarget-oqvzi6-0 evuxZm[/code]

MP3 properties:
[code]Title: "Nightcall (Raaja Bones & Fyfe Dangerfield Remix)"
Artists: "London Grammar"
Album: "Nightcall"
Album Artists: "London Grammar"[/code]

Do you need more details for investigation if all?

Thanks Zonky,

So I am better to use Lyricator with MMW4 for block updating with it 11(?) websites than looking up individual files with 7 sources.

[quote=IanRTaylorUK post_id=486400 time=1630788791 user_id=105749]
However, one thing I am not certain about. Is this add-on intended to be used on a single selection or cannot it be used to multi-select?
[/quote]
I've recently asked this question and was advised that this is not the case and there is no intention to do this since this might violate the websites policies for mass grabbing lyrics which will probably lead to a lockout of MM.

MM4 did not care about this, so I guess it's just a matter of time until MM5 will give us a bulk update of lyrics again. Otherwise the current lyrics feature is not very convenient...

Looks like a really useful add-on.

I have previously used Lyricator in MMW4 and so only have a few MP3 left without lyrics.

I tried the add-on but not finding lyrics - probably because there aren't any.

However, one thing I am not certain about. Is this add-on intended to be used on a single selection or cannot it be used to multi-select?

Been testing this add-on Tonight... Finding alot of lyrics I couldn't get before so thanks mate!! But it seems to not be grabbing all the lyrics, just part of them... But good job for your first add-on bro. I can't do anything like that so just wanted to say good job.

Approved! :slight_smile:

[quote=TIV73 post_id=486363 time=1630695810 user_id=49509]
Congratulations on your first addon!
[/quote]Well, not my [i]first[/i], but my first for MM5. ;)

[quote=drakinite post_id=486365 time=1630699448 user_id=107828]
Congrats; great work! However, before I can approve it: You forgot to fix that one error I pointed out earlier. The addon breaks when lyrics cannot be found, because you need to [i]call[/i] requestNext() on line 16. :slight_smile:

On the Submit Addon page, you should be able to edit the submitted version by clicking on Version Information on the right, then selecting a new file like so: http://files.drakinite.net/2021-09-03_15-58-51.mp4
[/quote]Fixed and submitted, thanks for the reminder.

[quote=fizzjob post_id=486360 time=1630694689 user_id=7616]
edit: ...and it's submitted! First time ever doing anything with node.js and npm. I'm learning all around today! :D
[/quote]

Congrats; great work! However, before I can approve it: You forgot to fix that one error I pointed out earlier. The addon breaks when lyrics cannot be found, because you need to [i]call[/i] requestNext() on line 16. :slight_smile:

On the Submit Addon page, you should be able to edit the submitted version by clicking on Version Information on the right, then selecting a new file like so: http://files.drakinite.net/2021-09-03_15-58-51.mp4

Congratulations on your first addon!