by Tippon » Mon Jul 05, 2021 9:10 pm
gbilley wrote: ↑Sun Jul 04, 2021 11:21 am
Thanks so much for leading me to a solution for the username-with-spaces issue. I'll get new and improved versions of freedbSubmitter, MonkeyBrainz, and DiscogsCSV online as soon as I can. But first, on to my next bone-head scripting error.
I think the solution will be to change line 655 to:
Code: Select all
temp = temp & "<p><a href='#' onclick='searchDiscid(" & category & "/" & discid & ")' hidefocus>View Details</a></p>"
The faulty code checks for disc collisions and is left over from the syntax used by the freedb.org website. When I switched to gnudb.org, I fixed the event handler, but not line 655 which calls the event handler. Part of the reason is because it's hard for me to check disc collisions.
It's working
I changed the code and launched MMW, and went through the steps to submit a CD. Everything worked as it should, and I had the option to submit the three discs I tried.
gbilley wrote: ↑Sun Jul 04, 2021 11:21 am
Be that as it may, is the Pilgrim CD a commercial disc, or has it been burned? If it's the latter, you may not want to submit that disc. Most music databases discourage or prohibit submitting burned CDs. You could submit it to MusicBrainz as a digital music release. After I fix the username bug in MonkeyBrainz, it should work for you.
FYI, I checked the Pilgrim discid in gnudb.org. It collides with an EP by a group called Pantera called Mouth of War. If you do submit it, you'll need to give it another freedb category (but you can leave the MM genre as Rock).
It's a professionally produced disc from an unsigned band, as is one of the others I tried. The main reason that I want to add discs is to put albums like these on, but I'm going to have to look into it more.
Both had conflicts, so I didn't submit them just in case. I tried the corrected version of Go Ahead Punk ...Make My Day, and was given the choice of the correct version or the incorrect version, so I selected the incorrect version and uploaded the changes. I've just checked, and the changes are showing on the site.
gbilley wrote: ↑Sun Jul 04, 2021 11:21 am
Thanks again for helping me track down my scripting bugs.
No problem
I'm just starting to learn Python and JavaScript, and I've needed plenty of help already, so it's nice to be able to help in some way, even if it's just going 'nah, that didn't work!'
[quote=gbilley post_id=483772 time=1625415664 user_id=86079]
Thanks so much for leading me to a solution for the username-with-spaces issue. I'll get new and improved versions of freedbSubmitter, MonkeyBrainz, and DiscogsCSV online as soon as I can. But first, on to my next bone-head scripting error.
I think the solution will be to change line 655 to:
[code]temp = temp & "<p><a href='#' onclick='searchDiscid(" & category & "/" & discid & ")' hidefocus>View Details</a></p>"[/code]
The faulty code checks for disc collisions and is left over from the syntax used by the freedb.org website. When I switched to gnudb.org, I fixed the event handler, but not line 655 which calls the event handler. Part of the reason is because it's hard for me to check disc collisions.[/quote]
It's working :)
I changed the code and launched MMW, and went through the steps to submit a CD. Everything worked as it should, and I had the option to submit the three discs I tried.
[quote=gbilley post_id=483772 time=1625415664 user_id=86079]
Be that as it may, is the Pilgrim CD a commercial disc, or has it been burned? If it's the latter, you may not want to submit that disc. Most music databases discourage or prohibit submitting burned CDs. You could submit it to MusicBrainz as a digital music release. After I fix the username bug in MonkeyBrainz, it should work for you.
FYI, I checked the Pilgrim discid in gnudb.org. It collides with an EP by a group called Pantera called Mouth of War. If you do submit it, you'll need to give it another freedb category (but you can leave the MM genre as Rock).[/quote]
It's a professionally produced disc from an unsigned band, as is one of the others I tried. The main reason that I want to add discs is to put albums like these on, but I'm going to have to look into it more.
Both had conflicts, so I didn't submit them just in case. I tried the corrected version of Go Ahead Punk ...Make My Day, and was given the choice of the correct version or the incorrect version, so I selected the incorrect version and uploaded the changes. I've just checked, and the changes are showing on the site.
[quote=gbilley post_id=483772 time=1625415664 user_id=86079]
Thanks again for helping me track down my scripting bugs.
[/quote]
No problem :)
I'm just starting to learn Python and JavaScript, and I've needed plenty of help already, so it's nice to be able to help in some way, even if it's just going 'nah, that didn't work!' :D