mp3tag's allmusic.com implementation

Download and get help for different MediaMonkey Addons.

Moderators: Peke, Gurus

Steegy
Posts: 3452
Joined: Sat Nov 05, 2005 7:17 pm
Location: Belgium
Contact:

Post by Steegy » Fri Mar 24, 2006 7:52 pm

You can use the command line switch from within MediaMonkey,
e.g. by using the following script (adds context menu items and a toolbar button with shortcut key Ctrl+E)

It's an autostart script (*.vbs file for MediaMonkey's Scripts\Auto folder)

Code: Select all

Option Explicit

Sub onStartUp 

   Dim CMIArray
   CMIArray = Array(SDB.UI.Menu_Pop_TrackList, SDB.UI.Menu_Pop_NP, SDB.UI.Menu_Pop_Tree, SDB.UI.Menu_TbStandard)
   
   Dim i, WSTItem
   For i = 0 To UBound(CMIArray)
     SDB.UI.AddMenuItemSep CMIArray(i), 0, 0
   
     Set WSTItem = SDB.UI.AddMenuItem(CMIArray(i), 0, 0) 
     WSTItem.Caption = "Web Sources Tagger"
     WSTItem.OnClickFunc = "RunTagger" 
     WSTItem.UseScript = Script.ScriptPath 
     WSTItem.IconIndex = 71
     WSTItem.ShortCut = "Ctrl+E"
   Next

End Sub 

Function RunTagger(arg) 

  Dim WShell, Result, Command

  Command = """C:\Program Files\Web Sources Tagger\Web Sources Tagger.exe"" /G"

  Set WShell = CreateObject("WScript.Shell") 
  Result = WShell.Run(Command, 1, 0)

End Function 
This script assumes that WST is installed as C:\Program Files\Web Sources Tagger\Web Sources Tagger.exe

Cheers
Steegy
Last edited by Steegy on Sun Sep 03, 2006 12:54 pm, edited 1 time in total.
Extensions: ExternalTools, ExtractFields, SongPreviewer, LinkedTracks, CleanImport, and some other scripts (Need Help with Addons > List of All Scripts).

urlwolf
Posts: 179
Joined: Sun Mar 05, 2006 6:58 am

Post by urlwolf » Fri Mar 24, 2006 10:04 pm

Steegy wrote: Hopefully this one will work well for all of you, but if there are any problems (except stability problems now and then :-? ) please let me know.
Very cool! this is really getting to be the best tagger all around.
A problem, though, is that sometimes the AMG parsing is not correct, For example, if I type:
Arias for Farinelli

It returns:

Vivica Genaux - Arias for Farinelli [<img src="/i/pages/site/icons/speaker.gif" border="0" alt="Listen Now!" title="Listen Now!" style="padding-top:1px;padding-right:2px;" />]

which is correct, mind you, but the extra tags make it not find the data :)

Thanks!

alphaex32
Posts: 8
Joined: Tue Mar 21, 2006 6:07 pm

Post by alphaex32 » Fri Mar 24, 2006 11:40 pm

Thanks for fixing it. The new version is really getting there, but there are a few things that could use work.

First, some of the tagging behavior isnt quite right. For example, you have the allmusic "moods" being displayed and tagged as %themes%. Mediamonkey has a "moods" tag, so that should be used for this. Also, maybe there could be an option to put "Themes" into the "Occasions" tag for mediamonkey (it seems like a pretty similar tag). Also, I personally would like an option to put the track artists into the "composer" tag. Another nice option would be to be able to pick a default web source.

One of the major causes of crashing seems to be too many search results. Maybe you could limit the number of results to improve stability?


Btw, can somebody make a magicnodes script that can parse the themes and moods tags using the "&" character and then sort them? I'm not sure if this is actually possible.

urlwolf
Posts: 179
Joined: Sun Mar 05, 2006 6:58 am

Post by urlwolf » Sat Mar 25, 2006 6:26 am

hmm, after using AMG a little more I think the results are really not that good, maybe I just tried really complicated ones.

AlbumPlayer gets the results right quite well actually, I wonder how they are doing it (in an unsupervised way, no less).

I agree with alphaex32... I cannot see most of the extra information that is (?) imported from AMG, like moods, etc. Related artists could be imported as links *within* the MM db, that'd be great.

Also, the album art is misteriously assigned to some of the tracks, but not others. Can you reproduce this?

Thanks

alphaex32
Posts: 8
Joined: Tue Mar 21, 2006 6:07 pm

Post by alphaex32 » Sat Mar 25, 2006 1:14 pm

urlwolf wrote:Also, the album art is misteriously assigned to some of the tracks, but not others. Can you reproduce this?
Yeah, I can confirm that I'm having this problem also. Some tracks just dont get tagged with album art unless I do them individually.

urlwolf
Posts: 179
Joined: Sun Mar 05, 2006 6:58 am

Post by urlwolf » Sat Mar 25, 2006 2:04 pm

hmm, I wonder if there is an easy way to talk to musicbrainz under this framework? AMG seems to be too noisy for the few CDs I have tried.

Steegy
Posts: 3452
Joined: Sat Nov 05, 2005 7:17 pm
Location: Belgium
Contact:

Post by Steegy » Sat Mar 25, 2006 7:04 pm

I have extra scripts:
  • artistdirect.src
  • Cover___iTunes.src
  • Lyrics__leoslyrics.src
  • Lyrics__magistrix.src
  • lyricsforall.src
  • musicbrainz.src
  • sing365.src
from Mp3Tag.

..and some variations on these (and the already included) scripts (e.g. "Discogs by Album" instead of "Discogs by Artist")
These variations will be merged in the future, so they will be selectable from the upper-left listbox as search type.

I haven't tested these scripts (completely) yet.
The goal is to improve & include all of these in the future.

Sources can always be added by yourself, if you take some time to make a script (!! lots of testing necessary !!).

And yes, AMG is a difficult source that needs a lot of work :cry:.
I am now experimenting with/enhancing the newer version of the "AMG Extended" script. It will include Style, Theme, Mood, Composer and maybe some other stuff.

Cheers
Steegy
Extensions: ExternalTools, ExtractFields, SongPreviewer, LinkedTracks, CleanImport, and some other scripts (Need Help with Addons > List of All Scripts).

psyXonova
Posts: 785
Joined: Fri May 20, 2005 3:57 am
Location: Nicosia, Cyprus
Contact:

Post by psyXonova » Tue Mar 28, 2006 6:56 am

Steegy
First of all thanks for this great plug-in.
Undoubtedly this plug-in sets the foundations for a major upgrade to MM functionality. Still, IMO, it needs more job to be a functional plug-in.
I have tried to tag a few albums with this plug-in. All of those albums had their tags (for artist and title and album) correct but they missed all the other info (e.g track number). So, i selected them and opened WSTagger from inside MM using the script u provided.
First mistake: tracklist was hidden by default... i had to spend enough seconds to realize that the empty list that appears was the results pane while tracklist had to be opened using "toggle tracklist". So, i toggled tracklist...
Second mistake: the window became oversized and couldnt browse the tracklist. An autofit to screen function could fix that (btw my resolution is 1024*768). I managed to overcome this by manually resizing and moving the window a couple of times.
I search Amazon.com for start. Results were right, nice job... but
Third mistake: Sort order of results didnt match the one in the tracklist. Perhaps that it why every track in the tracklist had a questionmark. I thought that WST will be able to sort that out so i press tag selected tracks. Well, WST didnt sort that out and incorrectly tagged my files....
I revert the tagging and tried MM's autotag from Amazon, this worked as it should, MM matched the results with the correct tracks and tagged them properly.
This last thing is very irritating but i am sure you can fix it...

That's for now. I am waiting for a new release of this great plug-in

Steegy
Posts: 3452
Joined: Sat Nov 05, 2005 7:17 pm
Location: Belgium
Contact:

Post by Steegy » Tue Mar 28, 2006 3:49 pm

Hello psyxonova

Some things in this thread:
- my request for giving suggestions to enhance the user interface and make it more usable and smaller, with the same information (mostly unanswered up to now)
- "known-problems" in one of my posts
- "what can it do" in one of my posts
might have answered some of your questions.

First of, the program dialog *is* too large. I have been working on this, and the new version to be released will have all less-used MediaMonkey-taggable fields (now added!) to the "More options" dialog (including the already included Custom1-3) to save space on the front panel. The masks for these fields are editable/enablable (right English ? :-? :lol: ) in the options dialog and will (for now) not be viewable in the front panel. A future version might include a "preview popup list" for those fields, but because they are mostly "Write-Once Read-Many" fields, that's not an issue for me personally. But please let me know if this would be an issue for you. Anyway, adding them to the "preview track listing" probably would be a better solution for this.

The hidable tracklist fits in the above strategy, but of course it makes much sense to automaticly open it when tracks are loaded from within MM. I have fixed this now. For people who don't want this behaviour (so don't automaticly open it), please let me know and I will maybe add an option.

As already said in this thread, the tracklist just provides a basic preview of what tracks have been loaded from MediaMonkey. It doesn't (yet) implements the recognition features like MM Amazon tagging has, and so the question marks have no meaning yet. That maybe explains your "results are sorted incorrectly" (well, actually *not* matched) problem.
Now, the tracklist represents the track info in MediaMonkey. I will change it so it gives a preview of the actual track changes, so you can see what will be tagged and what not (at least for the most important tags). That will give less problems with the misunderstanding about what will be tagged and what not, and if anything will change the displayed track order.

If anyone has a clue on how to create a "matching" algorithm to match found tracks with loaded ones, please let me know because for me it would just be trial and error, as this isn't an easy thing to do (certainly because people make so many mistakes in tagging their files/inconsistent tagging standards/incorrect submittings to the source websites).

It would be a big help if someone could explain me how MediaMonkey is doing it for album tagging.
I would use all available fields in an order of importance (e.g. Title, Artist, Song Length, ...) but the algorithm worries me.

In a previous release, I implemented a warning function before the actual tagging is done, but later removed it because it annoyed me and I would probably get complaints about it. But I do state that the tagging function has to be used with care.
As for me: I test the program on test/dummy mp3's, so there nothing will ever be changed to my real tracks.

First, this program was just a simple script parser using the Mp3Tag style, later I made it look very much like the MM Amazon tagging dialog, to keep the comfortable feeling. But if anyone things something should be made clearer.... please let me know.

BTW: I don't have found a listview control that has column checkboxes on it, so that is a major GUI problem for me. Can anyone help me with that? I think I will have to create it myself, but any help would be helpful. (subclassing the standard listview, intercepting move/resize events, place and move checkboxes on top accordingly --> would be the solution. That's also the one MM Amazon tagging uses if I'm correct).

BTW: If anyone encounters problems using the "link" between MediaMonkey and the tagger program, *that's not my fault*, and I can't help that. Restarting MediaMonkey should solve it's issue concerning COM.

Cheers
Steegy
Extensions: ExternalTools, ExtractFields, SongPreviewer, LinkedTracks, CleanImport, and some other scripts (Need Help with Addons > List of All Scripts).

judas
Posts: 572
Joined: Thu Jun 02, 2005 11:26 pm
Location: Bogotá, Colombia

Post by judas » Tue Mar 28, 2006 5:52 pm

Wow...thats quite a post. I wish i could help in something else than copmmenting on various things...anyway:

1. Im ok with the windows automatically expanding when importing files from MM....i guess thats what you want when clicking the button

2. I don't know about the matching algorithm...propably jiri or rusty or someone @MM can help you in this sense...as the Amazon's autotag works fairly well. I think the importance should be artist, album, title...i dont know about any of such algorithms...

3a. The change dialog sounds nice...specially at this early stage cause that would make it much easier to TEST. Could be tried on many tracks at once without risking the MP3s. I guess that would really speed the development of the scripts: now im afraid of tagging my REAL mp3...and tagging dummies doesn't make that sense: still you could only try tagging once every dummy...mmm...was i clear?? Actually, thinking about it, it would be the next thing i would implement, so to find the errors more easily.

3b. How about a dialog like auto-organize one? shows what has changed in different colors...

4. If the BEFORE/AFTER is implemented, there shouldnt be a need for a compare dialog.

Thats all I have to say about what you wrote for now...


Im just thinking out loud here:

How about a window that shows:

-On Top: search results...mostly as it is now.
-Bottom: 2 subwindows:
-One shows the track properties dialog as it was BEFORE
-Other (next to it) shows the track properties as it is going to be.

-The check boxes next to each field.

this way...y
*You could see the fields youre interested in...
*The learning curve would be almost flat as we're already used to this window by using MM track properties and amazon autotag
*Would be easily expandable to include other searches/modules in the future...Lyrics? Classic Music Database? New fields to come in MM? all can be added without much changing, as it would be consistent with MM.


so..there you go...gotta go now but will post any new ideas. (and maybe come up with something like a screen shot of what i just thought.


good luck...and keep it coming steegy.


judas

powerpill-pacman
Posts: 154
Joined: Mon Feb 21, 2005 1:07 pm
Location: berlin, germany
Contact:

Post by powerpill-pacman » Wed Mar 29, 2006 4:04 am

This really seems to be excellent, but i don't know how i get this to work. What do i have to install (web sources tagger. exe which is in the auto-script is nowhere to be found) and where do i have to install?

:oops: Edit: shame on me i finally realized that i need two zip-files, sorry.
Last edited by powerpill-pacman on Wed Mar 29, 2006 9:11 am, edited 1 time in total.

psyXonova
Posts: 785
Joined: Fri May 20, 2005 3:57 am
Location: Nicosia, Cyprus
Contact:

Post by psyXonova » Wed Mar 29, 2006 8:47 am

Hmmm, standard listview control that comes with VB6 and i think vb.net support checkboxes...

Have you tried the ctrListView.checkboxes = True ???

Steegy
Posts: 3452
Joined: Sat Nov 05, 2005 7:17 pm
Location: Belgium
Contact:

Post by Steegy » Wed Mar 29, 2006 11:30 am

The standard listview controls only include checkboxes for the main items (items in the first column), but not the sub items or the headers. Modified controls that have checkboxes for all items (in all columns, but not in the headers) already exist, but I need a listview control that has checkboxes in the column *headers*. I haven't found that yet. But thanks for the suggestion.

EDIT: I now have added some basic support for checkboxes on the listview headers, and this will be included in the next release (saving some place again).
Note to myself: next things = stability + preview tracklisting
Extensions: ExternalTools, ExtractFields, SongPreviewer, LinkedTracks, CleanImport, and some other scripts (Need Help with Addons > List of All Scripts).

Unlord
Posts: 17
Joined: Sun Feb 26, 2006 1:14 am

Post by Unlord » Thu Apr 13, 2006 1:21 pm

Just wondering if there have been any new developments on this recently, and where the newest version can bo downloaded from

Steegy
Posts: 3452
Joined: Sat Nov 05, 2005 7:17 pm
Location: Belgium
Contact:

Post by Steegy » Thu Apr 13, 2006 6:54 pm

Small report:

Code: Select all

Changes:
--------
A bit better design (main panel is now in "themed" tab style)
Better supported listviews:
 - found album tracks: checkboxes in the headers
 - tracklist (loaded from MM): all fields are editable (but are not yet saved)
 - preview (yellow fields indicate changes), can be toggled between preview and original
 - more options > tagging masks: added more masks that can be used (probably almost everything is present now)
Script directory can now be changed
Scripts from within that specified script directory are automatically added
Command line option to load a specified script file on startup (indicated by the position in the scripts list).
 Separators count as position too. E.g. use /SI:3 to load Amazon.co.uk, and use /SI:10 to load Discogs (once you see the program, you'll understand)
 Specification of scripts based on filename or script name could be made possible in the future, but the current solution is probably enough.
Added auto-matching from found album tracks with these selected from MediaMonkey (track numbers are matched by the track titles).

TODO additions:
---------------
Clean-up code
Save changes in tracklist to the matched internal tracklist, and save *that* list to the tracks in MM.
Better matching (e.g. incomplete tracknames should be better recognized)
I'm not releasing a new version yet, sorry.
Extensions: ExternalTools, ExtractFields, SongPreviewer, LinkedTracks, CleanImport, and some other scripts (Need Help with Addons > List of All Scripts).

Post Reply