Lyricator v1.4.4 (2019-06-23)

Post a reply


In an effort to prevent automatic submissions, we require that you complete the following challenge.
Smilies
:D :) :( :o :-? 8) :lol: :x :P :oops: :cry: :evil: :roll: :wink:
BBCode is ON
[img] is ON
[flash] is OFF
[url] is ON
Smilies are ON
Topic review
   

Expand view Topic review: Lyricator v1.4.4 (2019-06-23)

Re: Lyricator v1.4.4 (2019-06-23)

by thehammer » Fri Dec 06, 2019 3:49 pm

marqs wrote: ↑
Fri Dec 06, 2019 12:13 pm
 so i noticed a bug. the plugin cant find lyric to song with accents `´ at least with those. i had some songs like "Já estive aqui" and cannot find lyric on genius, but the rest of album songs it found. so i replaced de "já" for "ja" and it got the lyric. but it a bit annoying had to replace all and after rename again. hope you can fix this bug!! :D :D great work, i love the extension
Thanks for the report. I will add that to my list. I am working on an update that should be faster and more reliable with characters like this. Not sure when it will be done, but it's coming.

Re: Lyricator v1.4.4 (2019-06-23)

by marqs » Fri Dec 06, 2019 12:13 pm

so i noticed a bug. the plugin cant find lyric to song with accents `´ at least with those. i had some songs like "Já estive aqui" and cannot find lyric on genius, but the rest of album songs it found. so i replaced de "já" for "ja" and it got the lyric. but it a bit annoying had to replace all and after rename again. hope you can fix this bug!! :D :D great work, i love the extension

Re: Lyricator v1.4.4 (2019-06-23)

by thehammer » Thu Aug 29, 2019 4:46 pm

rvonder wrote: ↑
Thu Aug 29, 2019 2:26 am
 Hope I'm not covering old ground here, but I'm having a lot of trouble getting Lyricator to work consistently. I'm running the latest version of MM4 (4.1.25.1886) on Windows 10, although the problem also affected earlier versions. The Lyricator installation goes fine, and I'm using the current version (1.4.4.1).

I select all the tracks on a single album, right-click, and pick 'Scripts' followed by 'All configured sites'. The Lyricator dialog pops up, and a spinning circle appears in the upper-left corner. This happens about 90% of the time. Nothing else happens, no matter how long I wait. But every once in a while (the other 10%), I do exactly the same steps and it works perfectly. This seems to be totally random - I can't find any pattern to it occasionally working properly. (But when it does work, it's very fast and gives great results!)

This is driving me nuts: I've tried uninstalling Lyricator, exiting MM, and then re-installing... no improvement. When Lyricator hangs, I've tried exiting and restarting MM, but again, no improvement. Any ideas what causes it to hang most of the time, while still working occasionally? Thanks for any thoughts!
See http://www.mediamonkey.com/forum/viewto ... ni#p382090

Essentially this sounds like there are Lyricator configurations in multiple places and when the wrong one loads first it gives you this issue. You will need to uninstall, clean up all the configuration files of Lyricator settings and then re-install. I still haven't figured out how or when this happens but it may be that Lyricator was installed in two different modes (for all users, for one user, portable) at different points in time.

Re: Lyricator v1.4.4 (2019-06-23)

by rvonder » Thu Aug 29, 2019 2:26 am

Hope I'm not covering old ground here, but I'm having a lot of trouble getting Lyricator to work consistently. I'm running the latest version of MM4 (4.1.25.1886) on Windows 10, although the problem also affected earlier versions. The Lyricator installation goes fine, and I'm using the current version (1.4.4.1).

I select all the tracks on a single album, right-click, and pick 'Scripts' followed by 'All configured sites'. The Lyricator dialog pops up, and a spinning circle appears in the upper-left corner. This happens about 90% of the time. Nothing else happens, no matter how long I wait. But every once in a while (the other 10%), I do exactly the same steps and it works perfectly. This seems to be totally random - I can't find any pattern to it occasionally working properly. (But when it does work, it's very fast and gives great results!)

This is driving me nuts: I've tried uninstalling Lyricator, exiting MM, and then re-installing... no improvement. When Lyricator hangs, I've tried exiting and restarting MM, but again, no improvement. Any ideas what causes it to hang most of the time, while still working occasionally? Thanks for any thoughts!

Re: Lyricator v1.4.3 (2019-06-09)

by thehammer » Sun Jun 23, 2019 4:59 pm

kncuk1969 wrote: ↑
Sat Jun 22, 2019 5:53 am
 thehammer

I have looked at version 1.4.1.1(Apr 2018, last version to work with lyricsmode) and current 1.4.3.1 offering, also this was when I first started to find that some of them had to have the s added to http.

The sites that need changing to https are:
lyricsmode.com
elyrics.net

PS.
I have looked at lyricsfandom again and realised I forgot :oops: to add the s when I changed it from lyricswiki so the code should read.
'https://lyrics.fandom.com/wiki/%artist%:%title%'

PPS
Having scoured both JS files other than the current changes for genius I can't see any other changes that would change the searching to single letter song searches (so for my example of save a prayer it meant it searched s,a,v,e,p,r,y, but only on certain sites)

kncuk1969
Thanks for the info. I have updated those lyrics sites to https and updated the lyrics.fandom.com URL. I cannot reproduce what you are seeing with the Duran Duran song. My only suggestions would be to check your song title in the tag and MM library and/or maybe some the search option config for Lyricator like the delimiter array values.

Re: Lyricator v1.4.3 (2019-06-09)

by kncuk1969 » Sat Jun 22, 2019 5:53 am

thehammer

I have looked at version 1.4.1.1(Apr 2018, last version to work with lyricsmode) and current 1.4.3.1 offering, also this was when I first started to find that some of them had to have the s added to http.

The sites that need changing to https are:
lyricsmode.com
elyrics.net

PS.
I have looked at lyricsfandom again and realised I forgot :oops: to add the s when I changed it from lyricswiki so the code should read.
'https://lyrics.fandom.com/wiki/%artist%:%title%'

PPS
Having scoured both JS files other than the current changes for genius I can't see any other changes that would change the searching to single letter song searches (so for my example of save a prayer it meant it searched s,a,v,e,p,r,y, but only on certain sites)

kncuk1969

Re: Lyricator v1.4.3 (2019-06-09)

by thehammer » Fri Jun 21, 2019 8:44 pm

kncuk1969 wrote: ↑
Tue Jun 18, 2019 8:44 am
 With regards to this plugin, it would appear that both lyricsmode and lyricswiki have stopped finding lyrics, there were also a few others but putting https instead of http in the JS file sorted that out.

Now we know that lyricswiki changed to lyricsfandom but changing that detail in the JS file does nothing to improve things (so they have obviously changed something else)

I know that both the sites have the lyric as I looked on the corresponding sites (Duran Duran - Save a prayer) so not a new track as fandom have currently closed the site for new edits/songs, one other thing concerning the search for this song is that lyricator is doing it by single letter for both of these sites but complete words for the rest.

Now I presume that the code has not been changed for these two sites, as I have tagged lyrics from lyricsmode within the last year, but I have not checked any previous versions of the JS files.

kncuk1969
Thanks for the information. Which sites need to change to https? I remember some of the sites had lyrics that were sorted by the first letter of song or artist, but would have to look at the code to see which ones. Maybe this weekend I can look at lyricsfandom and see what has changed and if I can support it.

Re: Lyricator v1.4.3 (2019-06-09)

by kncuk1969 » Tue Jun 18, 2019 8:44 am

With regards to this plugin, it would appear that both lyricsmode and lyricswiki have stopped finding lyrics, there were also a few others but putting https instead of http in the JS file sorted that out.

Now we know that lyricswiki changed to lyricsfandom but changing that detail in the JS file does nothing to improve things (so they have obviously changed something else)

I know that both the sites have the lyric as I looked on the corresponding sites (Duran Duran - Save a prayer) so not a new track as fandom have currently closed the site for new edits/songs, one other thing concerning the search for this song is that lyricator is doing it by single letter for both of these sites but complete words for the rest.

Now I presume that the code has not been changed for these two sites, as I have tagged lyrics from lyricsmode within the last year, but I have not checked any previous versions of the JS files.

kncuk1969

Re: Lyricator v1.4.3 (2019-06-09)

by thehammer » Sun Jun 09, 2019 10:59 pm

Just put version 1.4.3 out there to fix Genius lyrics results that were getting leftover HTML junk in them.

Re: Lyricator v1.4.1 (2018-4-23)

by thehammer » Sat May 25, 2019 4:02 pm

It takes some JavaScript and VBScript knowledge, but a lot of that is copy, paste, and figure out what to change to add a new one. The most difficult part is figuring out how the new site URLs work and inspecting the page with browser developer tools to figure out how to extract the lyrics. I may be spending some time this weekend to put out a fix for Musixmatch. If you want to send me the site, maybe I can take a look and see if I can add it.

Re: Lyricator v1.4.1 (2018-4-23)

by Mikado86 » Fri May 24, 2019 8:16 pm

Can anyone post the instructions again to add a new lyrics site? i tried following the instructions but i am apparently too technologically impaired to make sense out of them

Re: Lyricator v1.4.1 (2018-4-23)

by Lowlander » Tue May 21, 2019 11:22 am

Likely: https://www.mediamonkey.com/forum/viewt ... cs+fetcher

Re: Lyricator v1.4.1 (2018-4-23)

by thehammer » Tue May 21, 2019 10:51 am

danQ wrote: ↑
Sat May 18, 2019 3:32 am
 I downloaded version 1.4.1.1 and tried to upgrade from v1.3.2.1, now I'm receiving the following error every time I bring up MM.

Error #-2147024894 -
File: "C:\Users\dvqumxppData\Roaming\MediaMonkey\Scripts\Auto\LyricsFetcher.vbs", Line: 4, Column: 1

Followed by:

Error happened during script execution:
The system Cannot find the file specified

When I go to the Extensions menu, I see both 1.3.2.1 and 1.4.1.1 are installed. I uninstalled both versions, and re-started MM. I still get the error even with the scripts uninstalled!

I don't see Lyricator on the: Options, Scripts, or Extensions Menu.

I'm confused.

Please help
That script has nothing to do with Lyricator. I don't have that .vbs file and don't see errors. It must be another plugin you have installed. You can search for that file being referenced in the scripts.ini file in "C:\Users\dvqumxppData\Roaming\MediaMonkey\Scripts" to track down what plugin it may have been.

Re: Lyricator v1.2.2 (2014-10-12)

by thehammer » Tue May 21, 2019 10:37 am

BionicRooster wrote: ↑
Thu Apr 04, 2019 9:42 am
tj_junk wrote: ↑
Fri Oct 17, 2014 1:25 am
 Suggestions:
  • Sort the Lyricator Submenu

    Code: Select all

    'To Add lyrics site add here
      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "Toolbar"
      lyricator_submenu.Caption = "All configured sites"
      lyricator_submenu.Hint = "Find lyrics using all lyrics sites chosen in Lyricator options"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "AZLyrics"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "ELyrics"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "Genius"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "Hiplyrics"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "Letras"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "LyrDB"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "LyricsMode"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "Lyricstime"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "LyricWikia"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "MetroLyrics"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "Mp3Lyrics"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "SeekALyric"

      Set lyricator_submenu = SDB.UI.AddMenuItem(lyricator_menu, 0, 0)
      lyricator_submenu.UseScript = Script.ScriptPath
      lyricator_submenu.OnClickFunc = "RunOneSite"
      lyricator_submenu.Caption = "SongColeta"
  • Rank the providers and sequence the searches accordingly

    Some providers are excellent: They have a high success rate for finding song lyrics, they return results quickly, and the lyrics are formatted well (e.g., with mixed case and grouped into logical paragraphs). Other providers are very poor: They have a low success rate, they are slow, and/or their lyrics are formatted poorly.

    After running several tests, i would rank the providers in the following order from best to worst, and would prefer that Lyricator search the best providers first.

    Code: Select all

    LyricsMode   (good success rate, very good formatting)
SongColeta   (good success rate, very good formatting)
LyrDB        (good success rate, good formatting)
Hiplyrics    (medium success rate, good formatting)
Genius       (medium success rate, good formatting)
SeekALyric   (medium success rate, fair-to-good formatting)
ELyrics      (medium success rate, fair formatting)
MetroLyrics  (medium success rate, poor formatting)
Letras       (medium success rate, poor formatting)
AZLyrics     (low success rate)
LyricWikia   (low success rate)
Mp3Lyrics    (very low success rate)
Lyricstime   (extremely slow, very low success rate)
In which file would I need to make this change?
Sorry that I haven't the time to support this plugin for a while. You could modify in the lyricator.js file in the plugins folder by changing the order that the lyrics site searches are added to the array (lines 136 through 256). The aR.include(..) lines are adding them to an array that is processed in the order they are added. I also noticed you still had Hiplyrics in your code snippet. That is old code removed two versions ago. Upgrade to 1.4.2.1 it has pretty much the same sorting and has Musixmatch with is a very good site.

Re: Lyricator v1.4.1 (2018-4-23)

by pheb62 » Sat May 18, 2019 4:43 am

Install v1.4 again.
Try to locate "C:\Users\dvqumxppData\Roaming\MediaMonkey\Scripts\Auto\LyricsFetcher.vbs"
or rather "C:\Users\dvqumxpp\Data\Roaming\MediaMonkey\Scripts\Auto\LyricsFetcher.vbs"
and check line 4 in the script, doesn't refer to a file there?

Either the wrong path TO the script is somewhere in the MM settings or config files, or the script itself is there and references a file that cannot be found.

Top